Touch now works on timeline bar. #4286
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_handleTouchMove was an old function that was removed (commit 1b1dea5). Replacing with _onTouchMove allows the touch to work on the timeline. To experience this bug: 1. Go to http://cesiumjs.org/Cesium/Apps/Sandcastle/index.html?src=Hello%20World.html&label=Showcases 2. Using touch (or an emulation in Chrome), touch the timeline bar (make sure it's touch, not a mouse). 3. Uncaught TypeError: timeline._handleTouchMove is not a function.
|
Thanks @thinkpadder1! Do we have a Contributor License Agreement (CLA) from you? If not, please follow the directions in CONTRIBUTING.md and send one over. |
|
Sorry, I am not going to sign it. But, feel free to close this request and have an existing maintainer commit it. |
Merged
|
Thanks again @thinkpadder1, I've opened up a PR here to fix the issue: #4305 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_handleTouchMove was an old function that was removed (commit 1b1dea5).
Replacing with _onTouchMove allows the touch to work on the timeline.
To experience this bug: